feat(linter): eslint-plugin-vitest/require-local-test-context-for-concurrent-snapshots #4578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
…oncurrent-snapshots
CodSpeed Performance ReportMerging #4578 will not alter performanceComparing Summary
|
mysteryven
reviewed
Jul 31, 2024
…oncurrent-snapshots
…oncurrent-snapshots
mysteryven
reviewed
Aug 2, 2024
mysteryven
suggested changes
Aug 6, 2024
| ("testSomething()", None), | ||
| ("xitSomethingElse()", None), | ||
| ("xitiViewMap()", None), | ||
| ("describe('foo', function () {})", None, None, Some(PathBuf::from(jest_path))), |
There was a problem hiding this comment.
We don't need to change test cases in rules, you can update path at once:
let path_to_lint = if self.import_plugin {
assert!(path.is_none(), "import plugin does not support path");
self.current_working_directory.join(&self.rule_path)
} else if let Some(path) = path {
self.current_working_directory.join(path)
+ } else if self.jest_plugin {
+ self.rule_path.with_extension("test.tsx")
} else {
self.rule_path.clone()
};There was a problem hiding this comment.
Okay, I'll updated it later.
|
This PR looks huge, can you split the bug fixes into another PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support eslint-plugin-vitest/require-local-test-context-for-concurrent-snapshots